Skip to content

Design feedback

Design feedback #1376

Triggered via pull request October 16, 2024 14:38
Status Success
Total duration 3m 49s
Artifacts 1

dev-n-ffprod-deploys.yml

on: pull_request
deploy-development  /  ...  /  build-app
deploy-development / webapp / build-app
deploy-development  /  ...  /  build-faucet
deploy-development / faucet / build-faucet
deploy-development  /  ...  /  build-onboarding-api
deploy-development / onboarding / build-onboarding-api
deploy-development  /  ...  /  build-pinning-api
deploy-development / pinning / build-pinning-api
deploy-development  /  ...  /  deploy-app
deploy-development / webapp / deploy-app
deploy-development  /  ...  /  deploy-faucet
deploy-development / faucet / deploy-faucet
deploy-development  /  ...  /  deploy-onboarding-api
deploy-development / onboarding / deploy-onboarding-api
deploy-development  /  ...  /  deploy-pinning-api
deploy-development / pinning / deploy-pinning-api
ff-prod  /  deploy-app
37s
ff-prod / deploy-app
deploy-development  /  ...  /  notify
deploy-development / webapp / notify
ff-prod  /  notify
2s
ff-prod / notify
Fit to window
Zoom out
Zoom in

Annotations

12 warnings and 1 notice
ff-prod / build-app
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c, actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ff-prod / build-app: centrifuge-app/src/components/InvestRedeem/InvestRedeemCentrifugeProvider.tsx#L100
React Hook React.useEffect has a missing dependency: 'connectedType'. Either include it or remove the dependency array
ff-prod / build-app: centrifuge-app/src/components/InvestRedeem/InvestRedeemDrawer.tsx#L77
React Hook React.useMemo has a missing dependency: 'pool.currency.decimals'. Either include it or remove the dependency array
ff-prod / build-app: centrifuge-app/src/components/PoolCard/index.tsx#L185
The 'calculateApy' function makes the dependencies of useMemo Hook (at line 223) change on every render. Move it inside the useMemo callback. Alternatively, wrap the definition of 'calculateApy' in its own useCallback() Hook
ff-prod / build-app: centrifuge-app/src/components/PoolList.tsx#L47
'isExtraLarge' is assigned a value but never used
ff-prod / build-app: centrifuge-app/src/components/PoolList.tsx#L130
'isExtraLarge' is assigned a value but never used
ff-prod / build-app: centrifuge-app/src/components/PoolOverview/TrancheTokenCards.tsx#L135
React Hook useMemo has a missing dependency: 'pool?.currency.symbol'. Either include it or remove the dependency array
ff-prod / build-app: centrifuge-app/src/components/PoolOverview/TrancheTokenCards.tsx#L149
React Hook useMemo has a missing dependency: 'calculateApy'. Either include it or remove the dependency array
ff-prod / deploy-app
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c, actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a, google-github-actions/auth@ef5d53e30bbcd8d0836f4288f5e50ff3e086997d, google-github-actions/setup-gcloud@62d4898025f6041e16b1068643bfc5a696863587. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ff-prod / deploy-app
Unexpected input(s) 'cors_config', valid inputs are ['bucket_url', 'GWIP', 'GSA', 'artifact_name']
ff-prod / deploy-app
Unexpected input(s) 'cors_config', valid inputs are ['bucket_url', 'GWIP', 'GSA', 'artifact_name']
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "webpack-ff-prod". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
front_URL
pr2504-app-ff-production.k-f.dev

Artifacts

Produced during runtime
Name Size
webpack-ff-prod Expired
8.79 MB