-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign feedback: Post Launch #2505
Comments
|
@kattylucy a few minor UI comments:
|
I spend some time today playing with the button - is this a MUST fix? Unfortunately the way we built our button system is causing the issue, we have the styling inside visualButton (which is a span element) and this component is inside a button element which is why we see the border going inwards. It's a bit time consuming to fix since we use button as for anchor tags and non-interactive elements and the reason on wny we have "visual button". I will have to rewrite visual button and have to change the use across the app. |
@kattylucy I see the issue.. Definitely not a clean fix, but wdyt about doing this for now: button {
border: 3px solid rgba(255, 226, 153, 0);
border-radius: 3px;
background-color: rgb(255, 192, 18);
:hover {
border-color: rgba(255, 226, 153, 100);
}
span {
border: none;
}
} It effectively shows up as an outset border from what I can check, because the button component has an invisible border at all times that just changes color on hover. If it doesn't work, I do think changing this border behaviour is quite important since it is visible across the app, but it is not critical today, can wait a few weeks. |
This doesn't work. I will create a ticket so I can spend more time fixing it and testing it across the app since this same button is what we use for anchor tags and other non-interactive buttons so we can't hard code the values. While I finish up assets redesign I can look into this! |
I just synced with Onno and he helped me out so all good! @hieronx |
@kattylucy looking really good now! Something is off with the y axis of the token price now, it is a straight line while it should be going up (min value of the y axis should be ~1.0, like it is on the live version on https://app.centrifuge.io/#/pools/4139607887) A few more minor comments, consider all of these nice to haves:
|
One more thing I noticed: when you click on a pool card from the landing page, or when you click on any other item in the side bar, the full page temporarily is white with a loading spinner in it. I don't think this is new behaviour, but because of the dark side bar it is now much more noticeable. Do you think it would be possible to change it such that the loading spinner for the new page load is contained within the main content, and the sidebar stays as is? I fear this might be somewhat complex, but it would make the page transitions significantly smoother, so I think it's worth exploring to at least estimate what the effort for this would be. Video of how it looks (loaded quite fast this time so it only flickers, but shows up much longer depending on page load time): |
We discussed yesterday during the sync to release the post launch fixes by latest tomorrow since there's two important bug fixes ( bug on pool performance chart, reports in the data tab not scrolling all the way down) - Sonam is meeting with Brian since they want to do some UI fixes for the landing page (based on feedback she got in NY) - Do you mind if we push this fix to this new ticket they will create? so we don't delay the deployment of the bug fixes @hieronx |
@kattylucy 100%, this is not that urgent, makes sense to me! |
Great, Im going to create the ticket so I make sure the work is completed. Thank you! |
Feel free to add all the feedback for the app redesign here. The work here is low priority and would be done POST launch (launch date is Oct 16)
The text was updated successfully, but these errors were encountered: