Post launch feedback updates #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
kattylucy
force-pushed
the
2505_post_launch_fixes
branch
from
60c8313
to
4da76fe
Compare
kattylucy
force-pushed
the
2505_post_launch_fixes
branch
from
20abc98
to
226fd0a
Compare
- Fix chart to calculate domain instead of rounding - remove junior from tooltip tranche if only one tranche - fix borders - adjust pool list to use grid system (easier to maintain than flex) - remove underline from tooltip for ratings
kattylucy
force-pushed
the
2505_post_launch_fixes
branch
from
226fd0a
to
d17153c
Compare
kattylucy
force-pushed
the
2505_post_launch_fixes
branch
from
1906e99
to
97ab29e
Compare
kattylucy
force-pushed
the
2505_post_launch_fixes
branch
from
6a15c8d
to
f5868e5
Compare
kattylucy
changed the title
kattylucy
force-pushed
the
2505_post_launch_fixes
branch
from
55d968c
to
98ee336
Compare
hieronx
reviewed
Oct 28, 2024
kattylucy
force-pushed
the
2505_post_launch_fixes
branch
from
b159ea7
to
dd5db7e
Compare
sophialittlejohn
approved these changes
Oct 29, 2024
| <Text style={{ marginLeft: 4 }}>{rating.value}</Text> | ||
| </Box> | ||
| </Tooltip> | ||
| {metadata?.pool?.poolRatings.map((rating: RatingType) => ( |
There was a problem hiding this comment.
Suggested change
| {metadata?.pool?.poolRatings.map((rating: RatingType) => ( | |
| {metadata?.pool?.poolRatings.map((rating) => ( |
shouldn't be necessary, think you can delete the type completely
Comment on lines
49
to
54
| export type RatingType = { | ||
| agency?: string | ||
| reportUrl?: string | ||
| reportFile?: any | ||
| value?: string | ||
| } |
There was a problem hiding this comment.
would extend this type from the metadata instead of creating a new type
kattylucy
force-pushed
the
2505_post_launch_fixes
branch
from
62a02ac
to
87417c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2505