Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centrifuge App: Add debug flag for pool create type #1563

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

onnovisser
Copy link
Collaborator

Description

This pull request...

Closes #

Approvals

  • Dev

Screenshots

Impact

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

PR deployed in Google Cloud
URL: https://app-pr1563.k-f.dev
Commit #: 2d22718
To access the functions directly check the corresponding deploy Action

@sophialittlejohn
Copy link
Collaborator

If the the createType is immediate I think we should hide the required deposit next to the cancel button since there is no deposit required as far as I know

@onnovisser
Copy link
Collaborator Author

onnovisser commented Sep 6, 2023

There's no proposal deposit in that case, but there's still a deposit required for the pool itself

Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@onnovisser onnovisser enabled auto-merge (squash) September 6, 2023 14:09
@onnovisser onnovisser merged commit bc39545 into main Sep 6, 2023
4 checks passed
@onnovisser onnovisser deleted the pool-create-type-debug-flag branch September 6, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants