Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Convert tax forms to optional step #1572

Merged
merged 12 commits into from
Sep 12, 2023

Conversation

sophialittlejohn
Copy link
Collaborator

@sophialittlejohn sophialittlejohn commented Sep 8, 2023

Description

This pull request...

  • makes tax info optional and includes it in the sign sub doc step if required by the issuer
  • provides a checkbox for issuers to make tax docs mandatory or not. Default is set to mandatory as soon as onboarding is enabled.

Closes #1569

Approvals

  • Dev
  • Dev
  • Designer
  • Product

Screenshots

Screenshot 2023-09-08 at 16 40 29 Screenshot 2023-09-08 at 16 41 07

Impact

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

PR deployed in Google Cloud
URL: https://app-pr1572.k-f.dev
Commit #: 99b6ff6
To access the functions directly check the corresponding deploy Action

</Shelf>
</Stack>
</Box>
{/* <Box p={4}> */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just remove?

@@ -6,41 +6,38 @@ const BASE_ENTITY_STEPS = {
VERIFY_BUSINESS: 3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user is on the tax upload step and then you refresh the page, does the app properly jump to the tax upload step?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now the tax step is included in the sign document step so no more official step for taxes. I just checked that refreshing the page puts you on the correct step

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok cool

@sophialittlejohn sophialittlejohn merged commit 2e038db into main Sep 12, 2023
10 checks passed
@sophialittlejohn sophialittlejohn deleted the onboarding/make-tax-step-optional branch September 12, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable mandatory tax upload in the onboarding app (Onboarding)
2 participants