ff-prod deploys (and less code) #1580
Conversation
gpmayorga
force-pushed
the
ff-prod-deploys
branch
2 times, most recently
from
385502c to
a464229
Compare
|
PR deployed in Google Cloud |
gpmayorga
force-pushed
the
ff-prod-deploys
branch
from
a464229 to
bfe8802
Compare
|
It looks like some of the inputs don't resolved properly both in the PR checks and in the PR job
|
|
A blip in the matrix, I think we're good |
|
Will they fix themselves when this PR is merged? |
|
Oh wait, I totally missed your point, you mean the ${{ inputs.environment }} Pushing a fix to try and setup default suffixes when skipped. |
Ok I tried a few options but it seems that since deploy_all.yml only trigger is being called by another workflow, the job names inside it will always be preceded by the parent workflow calling, so I don't think we really need unique names there. I've disabled the naming and replaced for much simpler indicative names |
| function_handler: faucet | ||
| concurrency: | ||
| group: 'faucet-api@${{ github.event.pull_request.head.label || github.head_ref || github.ref }}' | ||
| group: 'faucet-api--${{ inputs.deploy_env || github.event.inputs.deploy_env }}@${{ github.event.name }}${{ github.event.pull_request.head.label || github.head_ref || github.ref }}' |
There was a problem hiding this comment.
I see a double dash faucet-api--$ here, will that cause any problems?
* fix * typo and revert env
* add upcoming pools * reorder pools * fix alignment
gpmayorga
force-pushed
the
ff-prod-deploys
branch
from
4c894d4 to
dfbf31a
Compare
|
Closed in favor of #1598 |
Description
To deploy a "preview" of the main branch code pointing to the prod endpoints.
https://kflabs.slack.com/archives/C04GNE3JP6Z/p1683906262656619
Given the increasing number of "dual-deploys" I've rearranged things a little to allow to deploy to N environments on a given GH trigger.
Summary:
+ group common workflow code
+ universal "deploy all things" file
+ Less lines of code at the end 😎
+ Dual prod (from main branch) without additional config files
- main branch will now build all artifacts instead of selectively building depending on what folder changes
Check out the new main branch jobs deploying to 3 environments:
https://github.com/centrifuge/apps/actions/workflows/main-branch-deploys.yml
https://github.com/centrifuge/apps/actions/runs/6181041679
This pull request...
Saves some workflow code by grouping it and triggers deployments from main with prod config (app only)
Ah! And here's the preview:
https://app-ff-production.k-f.dev/pools