Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add upcoming pools #1586

Merged
merged 3 commits into from
Sep 18, 2023
Merged

add upcoming pools #1586

merged 3 commits into from
Sep 18, 2023

Conversation

jpangelle
Copy link
Contributor

@jpangelle jpangelle commented Sep 16, 2023

Description

This pull request adds the two upcoming pools, New Silver Series 3 and Flowcarbon Nature Offsets Series 2.

Closes #1582

Approvals

  • Dev
  • Product

Screenshots

image

@github-actions
Copy link

github-actions bot commented Sep 16, 2023

PR deployed in Google Cloud
URL: https://app-pr1586.k-f.dev
Commit #: 636c93a
To access the functions directly check the corresponding deploy Action

@annamehr
Copy link
Contributor

@jpangelle looks good! Small request can you display the upcoming pools at the beginning of the list instead of at the end? Then we show the new cool pools at the top.

@jpangelle
Copy link
Contributor Author

@jpangelle looks good! Small request can you display the upcoming pools at the beginning of the list instead of at the end? Then we show the new cool pools at the top.

done!

@sophialittlejohn
Copy link
Collaborator

The APR column looks like it should be aligned to the right side. Maybe by putting Target on the right side of the APR rather than the left it would look aligned again? Typically numbers are always right aligned in our tables

Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jpangelle jpangelle merged commit 955d727 into main Sep 18, 2023
7 checks passed
@jpangelle jpangelle deleted the upcoming-pools branch September 18, 2023 16:29
gpmayorga pushed a commit that referenced this pull request Sep 26, 2023
* add upcoming pools

* reorder pools

* fix alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Upcoming pools to Centrifuge app
3 participants