-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centrifuge App: Portfolio page #1590
Conversation
- add content structure - create AccountTokens - create AccountTransactions - create getAllTransactions related to one address
- creates PortfolioRewards - refactor 'useComputeLiquidityRewards' to accept an array of {poolId, trancheId} - refactor 'getBalances' to respect 'reserved' balance
- refactor computeReward to recall on all events - refactor claimLiquidityRewards to accept array of tranches
…-page
PR deployed in Google Cloud |
</PoolsTokensShared> | ||
</LayoutBase> | ||
) | ||
} | ||
|
||
function Pools() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved all the pool list filtering to the pool list component for easier reuse
import { useAddress } from '../../utils/useAddress' | ||
import { usePool } from '../../utils/usePools' | ||
|
||
const TOKEN_ITEM_COLUMNS = `250px 200px 100px 150px 1FR` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the plan for responsive design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure tbh, this was something Ben did before he left, but also keep in mind that a bunch of these components are just placeholders so whoever works on the composition table (#1594) will have to go over this again and make sure it looks right 😄
@@ -2015,6 +2015,159 @@ export function getPoolsModule(inst: Centrifuge) { | |||
) | |||
} | |||
|
|||
function getAllTransactions(args: [address: string]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noiceeee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ✅ ✅
Description
This pull request...
Relates to #1525
Approvals
Screenshots
Impact