Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centrifuge App: Portfolio page #1590

Merged
merged 18 commits into from
Sep 26, 2023
Merged

Centrifuge App: Portfolio page #1590

merged 18 commits into from
Sep 26, 2023

Conversation

sophialittlejohn
Copy link
Collaborator

@sophialittlejohn sophialittlejohn commented Sep 22, 2023

Description

This pull request...

  • adds portfolio page behind debug flag
  • implements not logged in state (page hidden) and logged in with no investments (pool list)
  • adds a framework for the rest of the portfolio components to be implements
  • implements the rewards card

Relates to #1525

Approvals

  • Dev
  • Dev
  • Designer
  • Product

Screenshots

Impact

Sorry, something went wrong.

Hornebom and others added 17 commits August 10, 2023 17:15
- add content structure
- create AccountTokens
- create AccountTransactions
- create getAllTransactions related to one address
- creates PortfolioRewards
- refactor 'useComputeLiquidityRewards' to accept an array of {poolId, trancheId}
- refactor 'getBalances' to respect 'reserved' balance
- refactor computeReward to recall on all events
- refactor claimLiquidityRewards to accept array of tranches
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

PR deployed in Google Cloud
URL: https://app-pr1590.k-f.dev
Commit #: fa0913c
To access the functions directly check the corresponding deploy Action

</PoolsTokensShared>
</LayoutBase>
)
}

function Pools() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved all the pool list filtering to the pool list component for easier reuse

@sophialittlejohn sophialittlejohn marked this pull request as ready for review September 26, 2023 16:21
import { useAddress } from '../../utils/useAddress'
import { usePool } from '../../utils/usePools'

const TOKEN_ITEM_COLUMNS = `250px 200px 100px 150px 1FR`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the plan for responsive design?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure tbh, this was something Ben did before he left, but also keep in mind that a bunch of these components are just placeholders so whoever works on the composition table (#1594) will have to go over this again and make sure it looks right 😄

@@ -2015,6 +2015,159 @@ export function getPoolsModule(inst: Centrifuge) {
)
}

function getAllTransactions(args: [address: string]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noiceeee

Copy link
Contributor

@jpangelle jpangelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@sophialittlejohn sophialittlejohn merged commit 0c7bd91 into main Sep 26, 2023
8 checks passed
@sophialittlejohn sophialittlejohn deleted the feat/portfolio-page branch September 26, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants