Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal assets #1606

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix internal assets #1606

merged 2 commits into from
Oct 2, 2023

Conversation

hieronx
Copy link
Contributor

@hieronx hieronx commented Oct 2, 2023

Description

This pull request...

Closes #

Approvals

  • Dev
  • Dev
  • Designer
  • Product

Screenshots

Impact

@hieronx hieronx requested a review from jpangelle October 2, 2023 11:03
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

PR deployed in Google Cloud
URL: https://app-pr1606.k-f.dev
Commit #: a78b7ad
To access the functions directly check the corresponding deploy Action

@hieronx hieronx requested a review from onnovisser October 2, 2023 11:09

return Object.values(currentValues)
.reduce((sum, value) => sum.add(value), Dec(0))
return loans
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, much cleaner!

@hieronx hieronx merged commit 4873b15 into oracle-v2 Oct 2, 2023
@hieronx hieronx deleted the internal-assets branch October 2, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants