Sign and remark attestation before updating NAV #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
onnovisser
reviewed
Oct 11, 2024
| ) | ||
| : substrate.selectedWallet | ||
| ? from( | ||
| cent.auth.generateJw3t(substrate.selectedAccount!.address, substrate.selectedWallet.signer as Signer) |
There was a problem hiding this comment.
The signed polkadot message should also have the portfolio content, otherwise it doesn't prove that the issuer attests to it. As the jw3t can't have any arbitrary content, we should probably use this: https://polkadot.js.org/docs/keyring/start/sign-verify/
…on-before-nav-update
… price doesn't update properly due to domain restrictions
onnovisser
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements signing a messages (attestations) before updating the nav. Substrate and EVM handle it slightly differently. For Substrate we're using signRaw and for EVM we're using EIP191 standard message signing.
#2431
Approvals
Screenshots
Impact