Add shadow background to nav bar #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
kattylucy
force-pushed
the
small_fixes_redesign
branch
from
41535b3 to
1b84886
Compare
hieronx
reviewed
Oct 16, 2024
| @@ -12,7 +13,7 @@ const Root = styled(Text)<{ isActive?: boolean; stacked?: boolean }>` | |||
| color: ${({ isActive, theme }) => (isActive ? theme.colors.textGold : theme.colors.textInverted)}; | |||
| font-size: 14px; | |||
| font-weight: 500; | |||
| background-color: transparent; | |||
There was a problem hiding this comment.
Could you change the margin left to match the margin right?
onnovisser
reviewed
Oct 16, 2024
| @@ -140,16 +148,21 @@ export function PoolCard({ | |||
| (key) => tinlakeTranches[key as TinlakeTranchesKey].name === name | |||
| ) || 'none') as TinlakeTranchesKey | |||
|
|
|||
| console.log(tinlakeKey, name) | |||
onnovisser
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes I noticed while going through the latest changes plus shadow background to side bar