Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool structure - create pool #2543

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

kattylucy
Copy link
Collaborator

@kattylucy kattylucy commented Nov 21, 2024

Review the pool structure section. There's some typescript and functionality to create a pool that is not implemented yet.

This review is mainly for UI work on the pool setup section

https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u/Pool-Overview%2F-Pool-Detail?node-id=3492-508&node-type=canvas&m=dev

  • Dev

@kattylucy kattylucy changed the title Fabric changes Pool structure Nov 21, 2024
@kattylucy kattylucy changed the title Pool structure Pool structure - create pool Nov 21, 2024
@kattylucy kattylucy requested review from sophialittlejohn and onnovisser and removed request for sophialittlejohn November 26, 2024 08:25
@kattylucy kattylucy marked this pull request as ready for review November 26, 2024 08:25
Copy link

PR deployed in Google Cloud
URL: https://pr2543-app-ff-production.k-f.dev
Commit #: 31489fd
To access the functions directly check the corresponding deploy Action

Copy link

PR deployed in Google Cloud
URL: https://app-pr2543.k-f.dev
Commit #: 31489fd
To access the functions directly check the corresponding deploy Action

@kattylucy kattylucy merged commit 439ae65 into create_pool_redesign Nov 27, 2024
11 checks passed
@kattylucy kattylucy deleted the create_pool_structure branch November 27, 2024 15:29
kattylucy added a commit that referenced this pull request Dec 13, 2024
* Add pool structure UI changes

* Small UI fix

* Avoid deletion on entries if less than one

* Add logic to single / multi sign

* Fix linter errors
kattylucy added a commit that referenced this pull request Dec 17, 2024
* Add pool structure UI changes

* Small UI fix

* Avoid deletion on entries if less than one

* Add logic to single / multi sign

* Fix linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant