Remove crowdloan pallets

[lemunozm]

Description

Remove:

• pallet-croddloan-claim
• pallet-crowdloan-reward
• libs/proofs (used only by them)
• Unused trait
• Storage from altair and centrifuge (Tech-debt)

[lemunozm]

I think we also need to create a migration to remove any storage from them

[wischli]

I think we also need to create a migration to remove any storage from them

Yes, we can use the runtime_common::migrations::KillPallet for that!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.47%. Comparing base (23d432c) to head (3683b6b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
- Coverage   48.54%   48.47%   -0.08%     
==========================================
  Files         169      165       -4     
  Lines       13370    12961     -409     
==========================================
- Hits         6491     6283     -208     
+ Misses       6879     6678     -201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lemunozm]

We have an issue removing the storage:

[2024-05-10T12:11:20Z INFO  runtime_common::migrations::nuke] Clear pallet "CrowdloanClaim": iteration result. backend: 10349 unique: 10349 loops: 10349

It's 259% heavier than a block, so we need to split this, which is not trivial I guess. Maybe we can leave the migration for another PR and start cleaning the repo now for the upgrade

[lemunozm]

@gpmayorga the PR still appears as failed when it shouldn't 🤔. Something missing?

[mustermeiszer]

It's 259% heavier than a block, so we need to split this, which is not trivial I guess. Maybe we can leave the migration for another PR and start cleaning the repo now for the upgrade

Multiblock migrations are maybe already available: paritytech/polkadot-sdk#1554

[wischli]

It's 259% heavier than a block, so we need to split this, which is not trivial I guess. Maybe we can leave the migration for another PR and start cleaning the repo now for the upgrade

Multiblock migrations are maybe already available: paritytech/polkadot-sdk#1554

Unfortunately, multiblock migrations are part of SDK v1.9.0.

IMO, it's absolutely feasible to keep the dead storage until then because it doesn't impose any risk. It just needs to be cleaned at some point.

[lemunozm]

Then, we can merge this!

[wischli]

I created a follow-up task: #1836

[lemunozm]

I already did it, but I close mine and use yours 👍🏻