Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup router invariants #397

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Setup router invariants #397

wants to merge 11 commits into from

Conversation

hieronx
Copy link
Contributor

@hieronx hieronx commented Aug 12, 2024

No description provided.


// forge test --match-test test_invariant_E_1_0 -vv
function test_invariant_E_1_0() public {
deployNewTokenPoolAndTranche(81, 113078215817378582107422693752520426616851634649913195634947047953023656943);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to assign some variable ( meaningful name ) to these magic numbers :D.
Wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are tests that are copy pasted as output of broken properties from medusa/echidna. So there is no meaningful names for these, and we shouldn't adapt these.

Copy link

Coverage after merging router-invariants into main will be

99.71%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Auth.sol100%100%100%100%
   CentrifugeRouter.sol91.06%61.54%100%99.08%102, 117, 128, 128, 145, 189, 200, 294, 302, 307, 309, 51, 58, 58, 58, 85
   ERC7540Vault.sol96.28%78.13%100%100%105, 133, 138, 145, 145, 250, 263
   Escrow.sol100%100%100%100%
   InvestmentManager.sol98.41%93.83%100%100%323, 354, 359, 488, 559
   PoolManager.sol99.01%98.17%96.43%100%216, 437
   Root.sol98.65%94.44%100%100%32
src/admin
   Guardian.sol92.59%100%100%85.71%65–66
src/factories
   ERC7540VaultFactory.sol100%100%100%100%
   TrancheFactory.sol100%100%100%100%
   TransferProxyFactory.sol100%100%100%100%
src/gateway
   GasService.sol100%100%100%100%
   Gateway.sol98.15%94.12%100%100%172, 176, 261–262, 76
src/gateway/adapters/axelar
   Adapter.sol100%100%100%100%
   Forwarder.sol100%100%100%100%
src/token
   ERC20.sol100%100%100%100%
   RestrictionManager.sol100%100%100%100%
   Tranche.sol92.98%70%94.44%100%108, 123, 97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants