Skip to content

Commit

Permalink
tools/crimson: fix cyanstore/memstore settings
Browse files Browse the repository at this point in the history
Signed-off-by: Xinyu Huang <[email protected]>
  • Loading branch information
aisakaki committed Jul 26, 2024
1 parent 635ed19 commit a990c28
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions tools/crimson/crimson_bench_tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -1249,8 +1249,8 @@ def general_pre_processing(self, tester_id):
self.additional_result['alien_thread_cpu_cores'] = crimson_alien_thread_cpu_cores
elif backend == "memstore":
osd_core_num = self.osd_core_num
command += " -o 'memstore_device_bytes = 8G'"
self.additional_result['memstore_device_bytes'] = '8G'
command += f" -o 'memstore_device_bytes = {self.args.memstore_device_bytes}'"
self.additional_result['memstore_device_bytes'] = self.args.memstore_device_bytes
elif backend == "seastore":
osd_core_num = self.osd_core_num
command += " -o 'seastore_cache_lru_size = 512M'"
Expand All @@ -1269,6 +1269,10 @@ def general_pre_processing(self, tester_id):
command += f" --crimson-smp {int(osd_core_num / self.args.osd)}"
else:
# classic
if backend == "memstore":
osd_core_num = self.osd_core_num
command += f" -o 'memstore_device_bytes = {self.args.memstore_device_bytes}'"
self.additional_result['memstore_device_bytes'] = self.args.memstore_device_bytes
if self.osd_core_num % self.args.osd != 0:
raise Exception("osd cores should be an integer multiple of osd")
# classic osd cores bounding will be setting after ceph start
Expand Down Expand Up @@ -1944,6 +1948,10 @@ def not_exist(tgt):
type=int,
default=None,
help='set ms_async_op_threads.')
parser.add_argument('--memstore-device-bytes',
type=str
default='8G'
help='set memstore_device_bytes for memstore')
parser.add_argument('--ceph-config', '--config',
type=str,
default=None,
Expand Down

0 comments on commit a990c28

Please sign in to comment.