Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE compile_commands flag addition #2270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CMAKE compile_commands flag addition #2270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/build_utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@ build_debs() {

echo building debs for $DIST

CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS $(extra_cmake_args)"
CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS $(extra_cmake_args)" + " -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=ON"
Copy link
Contributor

@tchaikov tchaikov Aug 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, scripts/build_utils.sh is used by the CI for building packages. and developers always just use the packages for testing and for redistributing Ceph. if that's the case, who will be reading the output of the linter?

Copy link
Member

@dmick dmick Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2269, as mentioned above, is meant to be a check job, but if it's got to run after a ceph build, I'm not sure how it fits in either.

DEB_BUILD_OPTIONS="parallel=$(get_nr_build_jobs)"

# pass only those env vars specifically noted
Expand Down