Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nagios aarch64 EPEL support #547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rosinL
Copy link
Member

@rosinL rosinL commented Mar 14, 2020

Signed-off-by: chuqifang [email protected]

@shrek-github
Copy link

Could one of the admins verify this patch, please?

2 similar comments
@shrek-github
Copy link

Could one of the admins verify this patch, please?

@shrek-github
Copy link

Could one of the admins verify this patch, please?

@shrek-github
Copy link

Could someone verify this patch, please?

@kevinzs2048
Copy link

@ktdreyer @akraitman Please help to review this patch.

We'd like to enable integration test on Arm64 architecture, so several different points have been identified in order to make the integration test happen on Arm64.

@kevinzs2048
Copy link

@rosinL @shrek-github Would be great if we can file a bug in Ceph Tracker.

@@ -30,6 +30,22 @@
- ansible_os_family == "RedHat"
- ansible_distribution_major_version|int <= 7
- have_epel.rc == 1
- ansible_architecture == "x86_64"

- name: Install nrpe without epel(aarch64)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title says "EPEL support" (which is not correct, because it's not supporting EPEL, it's getting the package from EPEL), the task title says "without epel" (which should be capitalized for consistency, too), but then the URLs are for mirrors of EPEL. So, 1) is it with or without EPEL? (clarify in the code) and 2) why a huawei mirror to the actual RPMs rather than the usual "install the EPEL repo ('epel-release') package, and then install the packages"?

@djgalloway djgalloway changed the base branch from master to main June 1, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants