-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding nagios aarch64 EPEL support #547
base: main
Are you sure you want to change the base?
Conversation
Could one of the admins verify this patch, please? |
2 similar comments
Could one of the admins verify this patch, please? |
Could one of the admins verify this patch, please? |
Could someone verify this patch, please? |
@ktdreyer @akraitman Please help to review this patch. We'd like to enable integration test on Arm64 architecture, so several different points have been identified in order to make the integration test happen on Arm64. |
@rosinL @shrek-github Would be great if we can file a bug in Ceph Tracker. |
roles/common/tasks/nagios.yml
Outdated
@@ -30,6 +30,22 @@ | |||
- ansible_os_family == "RedHat" | |||
- ansible_distribution_major_version|int <= 7 | |||
- have_epel.rc == 1 | |||
- ansible_architecture == "x86_64" | |||
|
|||
- name: Install nrpe without epel(aarch64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title says "EPEL support" (which is not correct, because it's not supporting EPEL, it's getting the package from EPEL), the task title says "without epel" (which should be capitalized for consistency, too), but then the URLs are for mirrors of EPEL. So, 1) is it with or without EPEL? (clarify in the code) and 2) why a huawei mirror to the actual RPMs rather than the usual "install the EPEL repo ('epel-release') package, and then install the packages"?
Signed-off-by: chuqifang <[email protected]>
aa17a2d
to
ab0620d
Compare
Signed-off-by: chuqifang [email protected]