Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing for multiple "public network" values. #132

Merged
merged 1 commit into from
Jul 8, 2014
Merged

Add parsing for multiple "public network" values. #132

merged 1 commit into from
Jul 8, 2014

Conversation

mdsteveb
Copy link

@mdsteveb mdsteveb commented Jul 1, 2014

This is a first pass at a fix for issue #131. ("It works for me!")

@guilhem guilhem self-assigned this Jul 3, 2014
@hufman
Copy link
Contributor

hufman commented Jul 7, 2014

Does having multiple networks in "public network" help for deployments where different servers are in different network ranges? When I tried running a mon with a multiple "public network" option, it used the first network and ignored the second. If that's intentional, than I think this looks good, and it worked in my tests.

@mdsteveb
Copy link
Author

mdsteveb commented Jul 8, 2014

That's my use case; I have a 3rd mon in another building on another subnet (but on the same LAN of course). My interpretation of the Ceph networking docs was that it was just looking for an interface which matched something in the public network list to choose as its public network. It didn't look like there was any intent to actually be able to select multiple interfaces or IPs simultaneously, but I wasn't looking for that either.

@mdsteveb
Copy link
Author

mdsteveb commented Jul 8, 2014

I should add that I'm having another problem after this in the deployment process and I can't tell if it's related. It's no longer crashing chef-client, but all my mon nodes are stuck on ceph-create-keys which of course is preventing anything else from working.

hufman added a commit that referenced this pull request Jul 8, 2014
Add parsing for multiple "public network" values.
@hufman hufman merged commit e25034d into ceph:master Jul 8, 2014
@hufman
Copy link
Contributor

hufman commented Jul 8, 2014

Code style checks out good, I like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants