Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix helm doc of ceph-csi deployment #4036

Merged
merged 1 commit into from
Aug 8, 2023
Merged

doc: fix helm doc of ceph-csi deployment #4036

merged 1 commit into from
Aug 8, 2023

Conversation

astraw99
Copy link
Contributor

@astraw99 astraw99 commented Aug 7, 2023

To make the doc better.

Describe what this PR does

Fix helm doc of ceph-csi deployment.

@mergify mergify bot added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Aug 7, 2023
@nixpanic
Copy link
Member

nixpanic commented Aug 7, 2023

Hi @astraw99, thanks for the PR! Could you update the commit message and add doc: as prefix to the subject of the commit? That way the commitlint CI job will pass, and tags will be added.

@astraw99 astraw99 changed the title Fix helm doc of ceph-csi deployment doc: fix helm doc of ceph-csi deployment Aug 8, 2023
@mergify mergify bot added bug Something isn't working ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Aug 8, 2023
@astraw99
Copy link
Contributor Author

astraw99 commented Aug 8, 2023

Hi @astraw99, thanks for the PR! Could you update the commit message and add doc: as prefix to the subject of the commit? That way the commitlint CI job will pass, and tags will be added.

Updated, PTAL thanks.

Rakshith-R
Rakshith-R reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can make the same changes in rbd helm readme too ?

https://github.com/ceph/ceph-csi/blob/ddcf88722beb280d0dd12c52ec1ce04150ae5ec4/charts/ceph-csi-rbd/README.md#install-chart

@Madhu-1 Madhu-1 requested a review from Rakshith-R August 8, 2023 09:05
@astraw99
Copy link
Contributor Author

astraw99 commented Aug 8, 2023

Can make the same changes in rbd helm readme too ?

https://github.com/ceph/ceph-csi/blob/ddcf88722beb280d0dd12c52ec1ce04150ae5ec4/charts/ceph-csi-rbd/README.md#install-chart

Done, PTAL thanks.

Rakshith-R
Rakshith-R approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Aug 8, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 8, 2023
@nixpanic
Copy link
Member

nixpanic commented Aug 8, 2023

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

queue

🛑 The pull request has been removed from the queue

Pull request #4036 has been dequeued due to failing checks or checks timeout.

You can take a look at Queue: Embarked in merge train check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member

nixpanic commented Aug 8, 2023

@Mergifyio rebase

@astraw99 @nixpanic
doc: fix helm doc of ceph-csi deployment
dc605c4 
To make the doc better.

Signed-off-by: astraw99 <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Aug 8, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 8, 2023
@mergify mergify bot merged commit 874d0bc into ceph:devel Aug 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@astraw99 @nixpanic @ceph-csi-bot @Madhu-1 @Rakshith-R @riya-singhal31