Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: enhance volumegroupsnapshot test #4934

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Oct 30, 2024

update the e2e for volumegroupsnapshot to create application pods from clone PVC and delete the pods once we are able to create the pods.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 30, 2024

/test ci/centos/mini-e2e-helm/k8s-1.31

@mergify mergify bot added the component/testing Additional test cases or CI work label Oct 30, 2024
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 30, 2024

@nixpanic i added few more steps to create pod and delete pod for the cloned volumes (part of volumegroupsnapshot)

@Madhu-1 Madhu-1 requested review from nixpanic and a team October 30, 2024 10:11
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mentioned just a nit

{
Name: "container",
Image: "quay.io/centos/centos:latest",
Command: []string{"/bin/sleep", "999999"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use sleep infinity instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think should be fine for now, i just copied it from other test file, planning for refractoring will take care of it in next PR.

@nixpanic
Copy link
Member

Tested with RBD VolumeGroupSnapshot in PR#4502.

@nixpanic nixpanic requested a review from a team October 31, 2024 18:23
Copy link
Contributor

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 4, 2024

@Mergifyio queue

Copy link
Contributor

mergify bot commented Nov 4, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f4f0304

update the e2e for volumegroupsnapshot
to create application pods from clone pvc
and delete the pods once we are able to
create the pods.

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 4, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 4, 2024
@mergify mergify bot merged commit f4f0304 into ceph:devel Nov 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing Additional test cases or CI work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants