Add a persistent UUID in create_bdev. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gil Bregman <[email protected]>
epuertat
reviewed
Aug 14, 2023
There was a problem hiding this comment.
When delivering a PR it's always good to connect it to existing issues or feature requests. In this very case, I think this PR might close:
The PR description and the commit message should contain a line Fixes: #<issue_id>. This is described here. If the new team members do want to reconsider that approach, feel free to bring this up.
…e persistent. So, whenever the gateway restarts or in case we connect from two gateways the same UUID would be used. So, whenever a bdev is created we generate a UUID in case we don't have one already. This UUID is written to the OMAP file so in case we restore a connection we fetch the UUID value from the OMAP file and use it. Signed-off-by: Gil Bregman <[email protected]>
…meof into uuid-in-create-bdev
trociny
approved these changes
Aug 14, 2023
|
@gbregman Could you please add the comment #181 (comment) to the commit log message? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the generated UUID to be persistent. So, whenever the gateway restarts or in case we connect from two gateways the same UUID would be used. So, whenever a bdev is created we generate a UUID in case we don't have one already. This UUID is written to the OMAP file so in case we restore a connection we fetch the UUID value from the OMAP file and use it.