Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller id range to ceph-nvmeof.conf and pass to gateway #186

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

gbregman
Copy link
Contributor

@gbregman gbregman commented Aug 16, 2023

Add controller id range to ceph-nvmeof.conf and pass to gateway. This allows using the partioning of controller id range between gateways, to be done later by Ceph-adm.

Related to issue #121

…teway. This allows using the partioning of controller

id range between gateways.

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman self-assigned this Aug 16, 2023
ceph-nvmeof.conf Outdated Show resolved Hide resolved
@gbregman gbregman requested a review from baum August 16, 2023 13:12
Copy link
Collaborator

@baum baum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🖖

control/grpc.py Outdated Show resolved Hide resolved
Copy link

@PepperJo PepperJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idryomov
Copy link
Contributor

idryomov commented Aug 16, 2023

@gbregman The commit message needs to be amended according to https://github.com/ceph/ceph-nvmeof/blob/devel/CONTRIBUTING.md#commit-format. In particular, the title should be short and separated from the body.

@idryomov
Copy link
Contributor

idryomov commented Aug 16, 2023

If you see GitHub truncating the commit title and showing ... there (in this case it also affects the PR title as there is just a single commit), it's good a sign that something is wrong ;)

…ateway.

This allows using the partioning of controller id range between gateways,
to be done later by Ceph-adm.

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman changed the title Add min and max controller id to ceph-nvmeof.conf and pass them to ga… Add controller id range to ceph-nvmeof.conf and pass to gateway Aug 17, 2023
@idryomov
Copy link
Contributor

@gbregman Please squash the second commit so that there is only one. The commit message still needs to be adjusted too. I would suggest:

control: add min and max controller id options

Add min and max controller id options to ceph-nvmeof.conf and pass
them to SPDK. This allows to partion the controller id range between
several gateways in a gateway group.

Fixes: #121

Signed-off-by: Gil Bregman <[email protected]>

Add min and max controller id options to ceph-nvmeof.conf and pass
them to SPDK. This allows to partion the controller id range between
several gateways in a gateway group.

Fixes: #121

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman merged commit 7aa987f into devel Aug 17, 2023
14 checks passed
@gbregman gbregman deleted the controller-range branch August 17, 2023 10:24
@idryomov
Copy link
Contributor

Please squash the second commit so that there is only one.

@gbregman This ended up with 4 commits, one of which is a bogus merge commit (while the "real" merge commit is missing Reviewed-by tags). Please don't merge PRs with outstanding comments even if the comment is not on the code itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants