-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add controller id range to ceph-nvmeof.conf and pass to gateway #186
Conversation
…teway. This allows using the partioning of controller id range between gateways. Signed-off-by: Gil Bregman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🖖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gbregman The commit message needs to be amended according to https://github.com/ceph/ceph-nvmeof/blob/devel/CONTRIBUTING.md#commit-format. In particular, the title should be short and separated from the body. |
If you see GitHub truncating the commit title and showing |
…ateway. This allows using the partioning of controller id range between gateways, to be done later by Ceph-adm. Signed-off-by: Gil Bregman <[email protected]>
@gbregman Please squash the second commit so that there is only one. The commit message still needs to be adjusted too. I would suggest:
|
Add min and max controller id options to ceph-nvmeof.conf and pass them to SPDK. This allows to partion the controller id range between several gateways in a gateway group. Fixes: #121 Signed-off-by: Gil Bregman <[email protected]>
…into controller-range
@gbregman This ended up with 4 commits, one of which is a bogus merge commit (while the "real" merge commit is missing |
Add controller id range to ceph-nvmeof.conf and pass to gateway. This allows using the partioning of controller id range between gateways, to be done later by Ceph-adm.
Related to issue #121