Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): Don't run build-container.yml on a schedule #198

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

epuertat
Copy link
Member

Commenting out schedule action to stop receiving run status reports. It looks like Github Actions designers decided that the committer that added the schedule line had to be the one receiving the job run emails forever, no matter they didn't make any further changes to that file.

Ideally, someone actively involved from the @ceph/nvmeof team should re-enable it (if deemed useful).

Commenting out `schedule` action to stop receiving run status reports. It looks like Github Actions designers decided that the committer that added the `schedule` line had to be [the one receiving the job run emails forever](https://github.com/orgs/community/discussions/25067), no matter they didn't make any further changes to that file.

Ideally, someone actively involved from the @ceph/nvmeof team should re-enable it (if deemed useful). 

Signed-off-by: Ernesto Puerta <[email protected]>
@idryomov
Copy link
Contributor

Commenting out schedule action to stop receiving run status reports. It looks like Github Actions designers decided that the committer that added the schedule line had to be the one receiving the job run emails forever, no matter they didn't make any further changes to that file.

So there is just no way to set the "actor" for a schedule explicitly?

Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: a title like "Don't run build-container.yml on a schedule" would be much more descriptive than "Update build-container.yml".

@epuertat epuertat changed the title refactor(ci): Update build-container.yml refactor(ci): Don't run build-container.yml on a schedule Aug 28, 2023
@epuertat
Copy link
Member Author

So there is just no way to set the "actor" for a schedule explicitly?

Seems so :/

That said, Github action failures will be posted also to the Ceph #nvmeof Slack channel (although I'm afraid that they might become too verbose/annoying). That can be configured with the /github unsubscribe commands.

@idryomov idryomov merged commit ad3821a into devel Aug 28, 2023
15 of 16 checks passed
@idryomov idryomov deleted the epuertat-patch-1 branch August 28, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants