Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in introduced in f88d9684 #257

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix typo in introduced in f88d9684 #257

merged 2 commits into from
Oct 10, 2023

Conversation

baum
Copy link
Collaborator

@baum baum commented Oct 10, 2023

Fix typo in config parameter name introduced in f88d968

Signed-off-by: Alexander Indenbaum <[email protected]>
@baum baum requested review from gbregman and caroav October 10, 2023 07:37
@gbregman
Copy link
Contributor

@baum
the multi gateway test source contains:

    pool = config.get("ceph", "pool")
    enable_discovery_controller = config.getboolean_with_default("gateway", "enable_discovery_controller", False)
    if not enable_discovery_controller:
         num_subsystems -= 1

But, the enable_discovery_controller parameter was removed from ceph-nvmeof.conf and is no longer used. You need to adjust the above code to the new logic.

Copy link
Contributor

@gbregman gbregman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi gateway test needs to be adjusted for new logic

Signed-off-by: Alexander Indenbaum <[email protected]>
@baum baum merged commit d24a890 into ceph:devel Oct 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants