Fix state test #849
Merged
Fix state test #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbregman
force-pushed
the
devel
branch
3 times, most recently
from
7ef0f8d
to
570f470
Compare
baum
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Thank you @gbregman 🖖 The change looks great 👍
Just a small improvement suggestion. Instead of repeatedly checking and sleeping, the test would wait only as long as necessary. Using an event makes it clear that the test is waiting for the _state_notify_update function to be triggered. This approach would provide a more robust and responsive way to verify that the notification mechanism is functioning correctly.
Fixes ceph#211 Signed-off-by: Gil Bregman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211