Implement inband authentication

[gbregman]

Implement inband authentication

[baum]

@gbregman looks great! A couple of thoughts on cosmetics and code organization of demo test variants in build-container.yml:

In .github/workflows/build-container.yml, we could define a demo matrix with three tests:

• 'demo',
• 'demosecuredhchap'
• 'demosecurepsk'

See pytest, ha matrices for instance.

For the Makefile:

• We could move key management code (e.g., /tmp/temp-psk/, /tmp/temp-dhcha/) out of build-container.yml into the appropriate make targets.
• We could move test logic (e.g., "verify connection list") out of build-container.yml into the appropriate make targets.
• The "Run bdevperf" step could be a Makefile target, e.g., make demo_bdevperf, demosecuredhchap_bdevperf, demosecurepsk_bdevperf.

The goal is to keep the GitHub workflow YAML definition lean, clean, and maintainable for the future.

wdyt?

[gbregman]

@baum we can't have the key files code in the make as this is done in the bdevperf container, not the gateway. The way it works is that the initiator (in this case bdevperf) needs to maintain the key files and keyring on his side. While the gateway code takes care of the target side. About the connection, it might be possible to move it I just followed what we had before. I don't see why it matters.

[gbregman]

@baum we can change the .yml file, but if we decide to do so I prefer to do it in a separate PR. I don't want to pack too many changes to one PR.

[baum]

Could you please address the test code issue before merging? Let me know if you need any assistance. Thank you!

[gbregman]

Could you please address the test code issue before merging? Let me know if you need any assistance. Thank you!

I already said that I prefer to do it in a separate PR.