Revert "Get rid of _t suffix"

In the very least, a change like this requires discussion on the list. The naming convention is goofy and it causes a massive merge problem. Something like this _must_ be presented on the list first so people can provide input and cope with it. This reverts commit 99a0949. Signed-off-by: Anthony Liguori <[email protected]>
ceph · Oct 1, 2009 · c227f09 · c227f09
1 parent 99a0949
commit c227f09
Show file tree

Hide file tree

Showing 316 changed files with 3,334 additions and 3,327 deletions.
diff --git a/CODING_STYLE b/CODING_STYLE
@@ -40,10 +40,14 @@ Rationale:
 
 3. Naming
 
-Variables are lower_case_with_underscores; easy to type and read.
-Structured type names are in CamelCase; harder to type but standing
-out.  Scalar type names are a_lower_case_beginning_with_an a or an.
-Do not use _t suffix if you are including any headers.
+Variables are lower_case_with_underscores; easy to type and read.  Structured
+type names are in CamelCase; harder to type but standing out.  Scalar type
+names are lower_case_with_underscores_ending_with_a_t, like the POSIX
+uint64_t and family.  Note that this last convention contradicts POSIX
+and is therefore likely to be changed.
+
+Typedefs are used to eliminate the redundant 'struct' keyword.  It is the
+QEMU coding style.
 
 4. Block structure
 

diff --git a/balloon.h b/balloon.h
@@ -16,12 +16,12 @@
 
 #include "cpu-defs.h"
 
-typedef a_ram_addr (QEMUBalloonEvent)(void *opaque, a_ram_addr target);
+typedef ram_addr_t (QEMUBalloonEvent)(void *opaque, ram_addr_t target);
 
 void qemu_add_balloon_handler(QEMUBalloonEvent *func, void *opaque);
 
-void qemu_balloon(a_ram_addr target);
+void qemu_balloon(ram_addr_t target);
 
-a_ram_addr qemu_balloon_status(void);
+ram_addr_t qemu_balloon_status(void);
 
 #endif