-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pydantic-settings as a dependency #57
Conversation
CI failure
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Maybe we can add a comment in the commit message about why we are changing this just to document it somewhere.
From what I understand, we are doing this because we are not using any complex settings types which pydantic-settings provides, so we are switching to reading env variables using dotenv and removing an extra dependency.
sure, i'll amend the commit message |
Use dotenv instead of pydantic-settings for loading environment variables from .env file. We are switching to dotenv as we are not using any complex types and don't require type checking for the variables. Signed-off-by: Devansh Singh <[email protected]>
Use
dotenv
library'sload_dotenv()
function instead ofpydantic-settings
for loading environment variables from.env
fileChecklist