Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicalConsole: Fix UTF-8 related failure #1880

Merged
merged 2 commits into from
Aug 2, 2023
Merged

PhysicalConsole: Fix UTF-8 related failure #1880

merged 2 commits into from
Aug 2, 2023

Conversation

zmc
Copy link
Member

@zmc zmc commented Aug 2, 2023

This is a re-file of #1879.

Fixes: https://tracker.ceph.com/issues/62286

@dmick, I'm not sure if this was your intent, but we're logging a lot more now after #1869. For example:

$ grep -a -A1 "console.*\(expect before\|output\):" /a/zack-2023-08-02_18:04:55-powercycle-reef-distro-default-smithi/7358307/teuthology.log > /tmp/7358307_console.txt
$ wc -l /tmp/7358307_console.txt
76 /tmp/7358307_console.txt
$ wc -c /tmp/7358307_console.txt
53344 /tmp/7358307_console.txt53344

@zmc zmc requested a review from dmick August 2, 2023 19:57
@dmick
Copy link
Member

dmick commented Aug 2, 2023

Yes, the excess logging is intentional. We don't have a clue why ipmitool is failing sometimes, so I'm attempting to find that out.

Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@zmc zmc merged commit ce5f6d5 into main Aug 2, 2023
9 checks passed
@dmick dmick deleted the wip-62286 branch August 2, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants