-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install/bin/stdin-killer: macOs (Darwin) compatibility #1895
Conversation
The failing check is addressed by #1894 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Signed-off-by: Leonid Usov <[email protected]>
7df85f2
to
7955b2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@zmc so may I merge it then? |
@batrick hm, I do not have access to teuthology on readthedocs, do you mind adding me? |
I'm not sure. You may be better asking @neha-ojha |
@batrick you're listed as an admin, but she's not: https://readthedocs.org/projects/teuthology/ |
Do you have a readthedocs username? Your emails didn't work in their lookup system. Mine for example is: https://readthedocs.org/profiles/batrick/ which I login to with via github auth. |
Yep, same for me - I hadn't added my RH email to the profile, but I've done that just now. |
I've invited you to both projects. |
Thanks! Appreciate it. |
No description provided.