teuthology/task/install: conditionally merge extra_system_packages ov… #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erride Fixes: https://tracker.ceph.com/issues/66093 Signed-off-by: Patrick Donnelly <[email protected]>
VallariAg
approved these changes
May 18, 2024
idryomov
added a commit
to idryomov/ceph
that referenced
this pull request
May 27, 2024
[1] and [2] added support for applying extra_system_packages overrides directly on install task, but at the same time broke our long standing workaround where we sneaked extra_system_packages directive in through an override on ceph task. This is likely getting addressed in [3], but it's better to not rely on this odd feature in the first place. [1] ceph/teuthology#1941 [2] ceph/teuthology#1943 [3] ceph/teuthology#1942 Fixes: https://tracker.ceph.com/issues/66232 Signed-off-by: Ilya Dryomov <[email protected]>
14 tasks
idryomov
added a commit
to idryomov/ceph
that referenced
this pull request
May 29, 2024
[1] and [2] added support for applying extra_system_packages overrides directly on install task, but at the same time broke our long standing workaround where we sneaked extra_system_packages directive in through an override on ceph task. This is likely getting addressed in [3], but it's better to not rely on this odd feature in the first place. [1] ceph/teuthology#1941 [2] ceph/teuthology#1943 [3] ceph/teuthology#1942 Fixes: https://tracker.ceph.com/issues/66232 Signed-off-by: Ilya Dryomov <[email protected]> (cherry picked from commit c61cb16)
idryomov
added a commit
to idryomov/ceph
that referenced
this pull request
May 29, 2024
[1] and [2] added support for applying extra_system_packages overrides directly on install task, but at the same time broke our long standing workaround where we sneaked extra_system_packages directive in through an override on ceph task. This is likely getting addressed in [3], but it's better to not rely on this odd feature in the first place. [1] ceph/teuthology#1941 [2] ceph/teuthology#1943 [3] ceph/teuthology#1942 Fixes: https://tracker.ceph.com/issues/66232 Signed-off-by: Ilya Dryomov <[email protected]> (cherry picked from commit c61cb16)
idryomov
added a commit
to idryomov/ceph
that referenced
this pull request
May 29, 2024
[1] and [2] added support for applying extra_system_packages overrides directly on install task, but at the same time broke our long standing workaround where we sneaked extra_system_packages directive in through an override on ceph task. This is likely getting addressed in [3], but it's better to not rely on this odd feature in the first place. [1] ceph/teuthology#1941 [2] ceph/teuthology#1943 [3] ceph/teuthology#1942 Fixes: https://tracker.ceph.com/issues/66232 Signed-off-by: Ilya Dryomov <[email protected]> (cherry picked from commit c61cb16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intermediate fix to get QA runs working again. The better approach will be done in #1942.