contextutil.safe_while does not sleep between tries if needed to loop infinitely #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshtsk
changed the title
added 3 commits
August 7, 2024 01:49
This patch fixes an issue introduced within PR ceph#1816, that when tries are < 0 (e.g. -1) there is no sleep occurred between tries. It also fixes error message, so we repot correct number of tries we've done now. Fixes: ee43f87 Signed-off-by: Kyr Shatskyy <[email protected]>
We only want to try to list_locks() for getting arch by machine_type when scheduling a suite. Otherwise we've got into an infinite loop and console log flooded with useless error messages. Signed-off-by: Kyr Shatskyy <[email protected]>
The list_locks has been updated with new argument 'tries' in PR#1816, but by unfortunate mistake hasn't been used yet. Fixes: 55886ea Signed-off-by: Kyr Shatskyy <[email protected]>
zmc
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides fixes for several issues introduced in #1816:
triesargument inlist_lock()instead of hardcoded infinite loopsafe_while()sleep between tries again whentries< 0, i.e. in case of infinite retrieslist_lock()only once when we're trying get architectures by given machine type forteuthology-suite.https://tracker.ceph.com/issues/67377