DRAFT: add caip ipld log #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachferland
commented
Nov 10, 2022
| } | ||
| type GenesisEvent struct { | ||
| header GenesisHeader | ||
| data Any | &Any |
There was a problem hiding this comment.
not sure how to define ANY or CID of ANY in ipld schema language
There was a problem hiding this comment.
Suggested change
| data Any | &Any | |
| data Any | Link |
zachferland
force-pushed
the
CAIPs/caip-ipld_log
branch
from
5aed49f to
9be7fb2
Compare
oed
reviewed
Nov 24, 2022
Comment on lines
+59
to
+68
| type DataHeader struct { | ||
| controllers optional [String] | ||
| } | ||
|
|
||
| type DataEvent struct { | ||
| id Link | ||
| prev Link | ||
| header optional DataHeader | ||
| data Any | &Any | ||
| } |
There was a problem hiding this comment.
Suggested change
| type DataHeader struct { | |
| controllers optional [String] | |
| } | |
| type DataEvent struct { | |
| id Link | |
| prev Link | |
| header optional DataHeader | |
| data Any | &Any | |
| } | |
| type Event GenesisEvent | DataEvent | AnchorDataEvent | |
| type DataHeader struct { | |
| controllers optional [String] | |
| } | |
| type DataEvent struct { | |
| id &GenesisEvent | |
| prev &Event | [&Event] | |
| header optional DataHeader | |
| data Any | Link | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening local PR again, to decide if want to make this a CAIP or not. It is very minimally defined to be a general CAIP. Have to decide if such a minimally defined spec is useful or not and if makes sense as a CAIP.