Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: Expect Merkle/witness CAR files to be always present #1170

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

gvelez17
Copy link
Contributor

This reverts commit 4deea40.

CAS started failing to anchor after deploy

Description

After a deploy from develop branch on Sep 20, CAS started failing to create anchors

Develop contained this list of commits

1c0675b
cd42df4
e63dc83
4deea40
078f0b2
afd6e20
07c3509
855c1b4
bbe02b3
aa3f27c
53ddac8

we could revert all of them, or only this one

4deea40

that caused the stricter CARfile handling. This PR reverts only the strict requirement for Merkle CARfile

How Has This Been Tested?

Describe the tests that you ran to verify your changes. Provide instructions for reproduction.

  • Test A (e.g. Test A - New test that ... ran in local, docker, and dev unstable.)
  • Test B

Definition of Done

Before submitting this PR, please make sure:

  • The work addresses the description and outcomes in the issue
  • I have added relevant tests for new or updated functionality
  • My code follows conventions, is well commented, and easy to understand
  • My code builds and tests pass without any errors or warnings
  • I have tagged the relevant reviewers
  • I have updated the READMEs of affected packages
  • I have made corresponding changes to the documentation
  • The changes have been communicated to interested parties

References:

Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

@gvelez17 gvelez17 requested review from ukstv and stbrody September 20, 2023 20:42
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15% 🎉

Comparison is base (1c0675b) 81.53% compared to head (095db35) 81.69%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1170      +/-   ##
===========================================
+ Coverage    81.53%   81.69%   +0.15%     
===========================================
  Files           46       46              
  Lines         1798     1797       -1     
  Branches       269      271       +2     
===========================================
+ Hits          1466     1468       +2     
+ Misses         332      329       -3     
Files Changed Coverage Δ
src/services/request-presentation-service.ts 91.66% <100.00%> (+10.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvelez17 gvelez17 marked this pull request as ready for review September 20, 2023 20:54
Copy link
Contributor

@smrz2001 smrz2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gvelez17 gvelez17 merged commit b613f22 into develop Sep 20, 2023
@gvelez17 gvelez17 deleted the revert-force-merkle-car branch September 20, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants