log model stream id

[gvelez17]

model stream id should be logged - #MET-1607

Description

The log data has been missing the model info. Upon examining a sample CARfile it seems that the genesisfields.header.model is an object, and we are trying to directly log it as a string. we need to extract the string.

Include relevant motivation, context, brief description and impact of the change(s). List follow-up tasks here.

How Has This Been Tested?

Describe the tests that you ran to verify your changes. Provide instructions for reproduction.

• added tests with a sample carfile that contains a model
• also included checks in tests without a model

Definition of Done

Before submitting this PR, please make sure:

• The work addresses the description and outcomes in the issue
• I have added relevant tests for new or updated functionality
• My code follows conventions, is well commented, and easy to understand
• My code builds and tests pass without any errors or warnings
• I have tagged the relevant reviewers

References:

Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (057158e) 81.56% compared to head (bd01b20) 81.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1176      +/-   ##
===========================================
+ Coverage    81.56%   81.57%   +0.01%     
===========================================
  Files           46       46              
  Lines         1801     1802       +1     
  Branches       293      276      -17     
===========================================
+ Hits          1469     1470       +1     
  Misses         332      332              

Files	Coverage Δ
src/services/request-service.ts	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stbrody]

lgtm mod one small suggested test cleanup

[stbrody]

actually wait, I'm not sure this will actually log the right thing. Have you tested this with a real MID stream's genesis commit? I think you need to do StreamID.fromBytes(genesisFields.model).toString()

[stbrody]

I'm not 100% positive though, so if you tested it with just calling toString on the Uint8Array and it printed the proper model streamid string we expect, then it's fine.

[gvelez17]

No, so the thing is, because we decode it actually model is an object.

so, the structure of 'model' depends on whether it was run thru decode or not

carFile.get(genesisJWS.link).header.model

Uint8Array(40)


decode(IpfsGenesis, carFile.get(genesisJWS.link)).header.model

{ _tag: Symbol(@ceramicnetwork/streamid/StreamID),

_type: 2,

_cid: CID }

and in our case, it is using decode

ceramic-anchor-service/src/services/metadata-service.ts

Line 98 in 057158e

const genesis = decode(IpfsGenesis, genesisRecord)

const genesis = decode(IpfsGenesis, genesisRecord)
return genesis.header

[gvelez17]

@stbrody fyi ^^ so i commited your change, will merge when it completes

[stbrody]

Ah I see, we use the codec to deserialize the genesis commit, so it's already a StreamID instance by the time we get here. Sounds good.