Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be compatible with the infra-wide setting for metrics port #1177

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

gvelez17
Copy link
Contributor

@gvelez17 gvelez17 commented Nov 7, 2023

Enable Prometheus Scraping of Metrics - #INFRA-14

Description

The historical environment variable is METRICS_PORT, across different node types. Better to be consistent.

This will allow us to turn on prometheus endpoint to be scraped on cas.

How Has This Been Tested?

Describe the tests that you ran to verify your changes. Provide instructions for reproduction.

  • [x ] Unit tests

Definition of Done

Before submitting this PR, please make sure:

  • [ x] The work addresses the description and outcomes in the issue
  • I have added relevant tests for new or updated functionality
  • My code follows conventions, is well commented, and easy to understand
  • [x ] My code builds and tests pass without any errors or warnings
  • [x ] I have tagged the relevant reviewers
  • I have updated the READMEs of affected packages
  • I have made corresponding changes to the documentation
  • [ x] The changes have been communicated to interested parties

References:

Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2061e07) 81.57% compared to head (a3f4ce7) 81.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1177   +/-   ##
========================================
  Coverage    81.57%   81.57%           
========================================
  Files           46       46           
  Lines         1802     1802           
  Branches       276      276           
========================================
  Hits          1470     1470           
  Misses         332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvelez17 gvelez17 requested review from 3benbox and smrz2001 November 9, 2023 17:53
Copy link
Contributor

@3benbox 3benbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gvelez17 gvelez17 merged commit 7a08a97 into develop Nov 10, 2023
3 checks passed
@gvelez17 gvelez17 deleted the feat/add-and-modify-infra-compatible-settings branch November 10, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants