Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only create request if it does not exist #1190

Conversation

stephhuynh18
Copy link
Contributor

problem: we used to merge on conflict when creating requests. This can result in multiple messages set to the scheduler, and misleading log messages

fix: ignore on conflict

added unit tests

Copy link

linear bot commented Apr 4, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.29%. Comparing base (14771a4) to head (0b745f7).

Files Patch % Lines
src/controllers/request-controller.ts 88.88% 1 Missing ⚠️
src/services/__tests__/fake-factory.util.ts 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1190      +/-   ##
===========================================
- Coverage    81.30%   81.29%   -0.02%     
===========================================
  Files           46       46              
  Lines         1819     1828       +9     
  Branches       285      289       +4     
===========================================
+ Hits          1479     1486       +7     
- Misses         340      342       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stbrody stbrody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephhuynh18 stephhuynh18 merged commit 14badfd into develop Apr 5, 2024
6 checks passed
@stephhuynh18 stephhuynh18 deleted the feature/ws2-3147-dont-send-duplicate-sqs-messages-from-cas-api branch April 5, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants