Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metric for anchor accepted #1191

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

gvelez17
Copy link
Contributor

@gvelez17 gvelez17 commented Apr 17, 2024

Add controller metric for Anchor Request Accepted - #WS2-3180

Description

add metric to cas for anchor accepted

How Has This Been Tested?

Describe the tests that you ran to verify your changes. Provide instructions for reproduction.

  • [x ] unit tests

metrics generally will not have prod impacting failures

Definition of Done

Before submitting this PR, please make sure:

  • The work addresses the description and outcomes in the issue
  • I have added relevant tests for new or updated functionality
  • My code follows conventions, is well commented, and easy to understand
  • My code builds and tests pass without any errors or warnings
  • I have tagged the relevant reviewers
  • I have updated the READMEs of affected packages
  • I have made corresponding changes to the documentation
  • The changes have been communicated to interested parties

References:

Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

@gvelez17 gvelez17 marked this pull request as ready for review April 17, 2024 18:31
@gvelez17 gvelez17 requested a review from samika98 April 17, 2024 18:31
@gvelez17
Copy link
Contributor Author

Mohsin wants a few more things so no rush, may add more here

Copy link
Contributor

@samika98 samika98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some changes for renaming based on how the API is being used by js-ceramic :)

src/controllers/request-controller.ts Show resolved Hide resolved
@gvelez17 gvelez17 requested a review from smrz2001 April 17, 2024 20:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.32%. Comparing base (96f079a) to head (f954794).
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1191      +/-   ##
===========================================
+ Coverage    81.29%   81.32%   +0.03%     
===========================================
  Files           46       46              
  Lines         1828     1831       +3     
  Branches       289      289              
===========================================
+ Hits          1486     1489       +3     
  Misses         342      342              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samika98 samika98 self-requested a review April 17, 2024 21:34
Copy link
Contributor

@samika98 samika98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvelez17 gvelez17 merged commit 516cc99 into develop Apr 17, 2024
6 checks passed
@gvelez17 gvelez17 deleted the feat/add-anchor-accepted-metric branch April 17, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants