-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metric for anchor accepted #1191
Conversation
Mohsin wants a few more things so no rush, may add more here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some changes for renaming based on how the API is being used by js-ceramic :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1191 +/- ##
===========================================
+ Coverage 81.29% 81.32% +0.03%
===========================================
Files 46 46
Lines 1828 1831 +3
Branches 289 289
===========================================
+ Hits 1486 1489 +3
Misses 342 342 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add controller metric for Anchor Request Accepted - #WS2-3180
Description
add metric to cas for anchor accepted
How Has This Been Tested?
Describe the tests that you ran to verify your changes. Provide instructions for reproduction.
metrics generally will not have prod impacting failures
Definition of Done
Before submitting this PR, please make sure:
References:
Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.