fix: move db connection outside handler, too many open files #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvelez17
reviewed
Apr 19, 2024
|
Great catch! Have we tested it? |
It's running on dev now. |
|
um - won't the next time we merge to develop automatically deploy develop branch to dev-cas - i think if its already running on dev cas we should def merge this? |
We never had CD for CAS Auth unfortunately. Whenever we merge this, the CD will run but that just deploys regular CAS code, not Auth code. We'll have to manually deploy the Lambda to all the envs. |
|
per Mohson we are not affecting the anchoring in this pr, force-merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During load testing on CAS, we're getting error "EMFILE: too many files open".