Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade observability package for better error logging #1211

Merged
merged 5 commits into from
May 17, 2024

Conversation

gvelez17
Copy link
Contributor

Upgrade observability package - better error logging

Description

This just provides better error logging when metrics fails to start because of invalid parameters

@gvelez17 gvelez17 marked this pull request as ready for review May 15, 2024 08:05
@gvelez17 gvelez17 requested a review from smrz2001 May 15, 2024 08:06
@gvelez17 gvelez17 changed the title upgrade observability package upgrade observability package for better error logging May 15, 2024
@gvelez17
Copy link
Contributor Author

weird a rebase shouldn't have duplicated the commits, i dunno why that happened

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.46%. Comparing base (9fe18f0) to head (e09ccb2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1211      +/-   ##
===========================================
- Coverage    79.72%   79.46%   -0.27%     
===========================================
  Files           47       47              
  Lines         1899     1899              
  Branches       301      301              
===========================================
- Hits          1514     1509       -5     
- Misses         385      390       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvelez17 gvelez17 merged commit 9e952f0 into develop May 17, 2024
6 checks passed
@gvelez17 gvelez17 deleted the chore/bump-observability branch May 17, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants