Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reuse connections in dynamodb http client #1226

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

smrz2001
Copy link
Contributor

Ported over @samika98's SQS client code to the DynamoDB client.

@smrz2001 smrz2001 self-assigned this Jun 11, 2024
@smrz2001 smrz2001 enabled auto-merge (squash) June 11, 2024 22:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15%. Comparing base (5376fc8) to head (406ebc6).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1226      +/-   ##
===========================================
- Coverage    76.42%   76.15%   -0.27%     
===========================================
  Files           44       44              
  Lines         1862     1862              
  Branches       314      301      -13     
===========================================
- Hits          1423     1418       -5     
- Misses         439      444       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@samika98 samika98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smrz2001 smrz2001 merged commit 78a8848 into develop Jun 11, 2024
5 checks passed
@smrz2001 smrz2001 deleted the feat/dynamodb-conn-reuse branch June 11, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants