Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving ts-essentials to global dependencies #26

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

mzkrasner
Copy link
Contributor

  • ts-essentials package needed for http-client (and other packages) to run, but had not previously been listed as package dependency in http-client package
  • Moved to the SDK's global dependencies list (version matching based on usage across 4 other packages)
  • Removed as local package dependencies from events, model-instance-handler, model-instance-protocol, and model-protocol

@stbrody stbrody assigned mzkrasner and unassigned stbrody Nov 6, 2024
@stbrody
Copy link

stbrody commented Nov 6, 2024

seems reasonable to me but I don't really know much about TS transpilation. @ukstv could you possibly take a quick look at this?

CC @nathanielc

@stbrody stbrody requested a review from ukstv November 6, 2024 17:48
Copy link

@ukstv ukstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all dev dependencies, so LGTM.

@mzkrasner mzkrasner merged commit ca931a3 into main Nov 6, 2024
5 checks passed
@mzkrasner mzkrasner deleted the mzk/deps-fix branch November 6, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants