Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of TACo + ComposeDB Example Integration #108

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Addition of TACo + ComposeDB Example Integration #108

merged 6 commits into from
Oct 22, 2024

Conversation

mzkrasner
Copy link
Contributor

Includes:

  • Changes to the side menu to house a new page under the "Tutorials and Examples" denomination
  • The new "TACo with ComposeDB" page itself which has already been proofed for grammar and spelling

@mzkrasner mzkrasner requested a review from JustinaPetr October 21, 2024 15:27
arjunhassard
arjunhassard approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@arjunhassard arjunhassard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An exciting step for web3 infrastructure!

docs/composedb/examples/taco-access-control.mdx Outdated Show resolved Hide resolved
docs/composedb/examples/taco-access-control.mdx Outdated Show resolved Hide resolved
docs/composedb/examples/taco-access-control.mdx Outdated Show resolved Hide resolved
docs/composedb/examples/taco-access-control.mdx Outdated Show resolved Hide resolved
docs/composedb/examples/taco-access-control.mdx Outdated Show resolved Hide resolved
@mzkrasner
Copy link
Contributor Author

Thanks @arjunhassard for the helpful edits! This looks good to me. I am passing it to @JustinaPetr for final approval.

JustinaPetr
JustinaPetr approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@JustinaPetr JustinaPetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! @mzkrasner Feel free to merge.

@mzkrasner mzkrasner merged commit 0a92347 into main Oct 22, 2024
1 check passed
@mzkrasner mzkrasner deleted the mzk/taco-example branch October 22, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinaPetr JustinaPetr JustinaPetr approved these changes

@arjunhassard arjunhassard arjunhassard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzkrasner @arjunhassard @JustinaPetr