Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added metrics docs #52

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Added metrics docs #52

merged 2 commits into from
Jan 4, 2024

Conversation

3benbox
Copy link
Contributor

@3benbox 3benbox commented Jan 4, 2024

First pass at metrics doc for js-ceramic.

@JustinaPetr
Copy link
Contributor

Thank you @3benbox! Looks good to me.

gvelez17
gvelez17 suggested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@gvelez17 gvelez17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to get this in, i think its worth also making it consistent?

gvelez17
gvelez17 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@gvelez17 gvelez17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@3benbox 3benbox merged commit b9b698d into main Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinaPetr JustinaPetr JustinaPetr approved these changes

@gvelez17 gvelez17 gvelez17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3benbox @JustinaPetr @gvelez17