feat: send js-ceramic and ceramic-one versions to CAS when creating requests #3246
Conversation
stbrody
changed the title
| Metrics.observe(VERSION_INFO, 1, { | ||
| jsCeramicVersion: this._versionInfo.cliPackageVersion, | ||
| jsCeramicGitHash: this._versionInfo.gitHash, | ||
| ceramicOneVersion: ipfsVersion, | ||
| ceramicOneVersion: this._versionInfo.ceramicOneVersion, |
There was a problem hiding this comment.
a small downside of this is that if ipfs/ceramic-one is upgraded out from under a running js-ceramic node, the js-ceramic node will continue to report the old version of ipfs/C1 until js-ceramic restarts. Since it should be rare to upgrade C1 without also at least restarting js-ceramic, I think this is acceptable.
There was a problem hiding this comment.
yeah i think thats a really weird edge case, and we can also tell when it happens. i think this metric is fine
| stateStoreDirectory, | ||
| anchorOnRequest: false, | ||
| indexing: { | ||
| db: `sqlite://${stateStoreDirectory}/ceramic.sqlite`, |
There was a problem hiding this comment.
is sqlite hardcoded in? just a side question
There was a problem hiding this comment.
This is a test file, so yes this test always uses sqlite
| disableComposedb: true, | ||
| enableHistoricalSync: false, | ||
| }, | ||
| pubsubTopic: '/ceramic/inmemory/test', // necessary so Ceramic instances can talk to each other |
There was a problem hiding this comment.
would like to see a constant for this
There was a problem hiding this comment.
this is just a test file, the value used here could be anything
stbrody
force-pushed
the
send-version-to-cas-aes-133
branch
from
c930424 to
83d94cb
Compare
js-ceramic half corresponding to ceramicnetwork/ceramic-anchor-service#1232
Builds on #3245