feat: add ipfs metrics #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can separately see calls counts and durations to Ipfs operations directly. Instead of only the toplevel Kubo RPC API requests.
nathanielc
force-pushed
the
feat/ipfs-metrics
branch
from
8e96770 to
4419568
Compare
AaronGoldman
approved these changes
Nov 2, 2023
|
Yeah I want to make this middle metrics pattern generic. But that is going to take some thinking so for now I am just being very verbose about it. But no need to worry to forget about it, compiler will remind you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can separately see calls counts and durations to Ipfs operations directly. Instead of only the toplevel Kubo RPC API requests.