chore: use latest stable openapi-generator-cli #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
chore/openapi
branch
from
10fe2ee to
d84566e
Compare
Turns out that the openapi-generator-cli npm crate is a whole major version behind (6 vs 7) of the openapi-generator jar. This change removes the usage of the npm package as it was only a wrapper for downloading the jar and running it. Now we have a simple bash script that uses that latest stable release of openapi-generator. This means we now have the fix for the extra .clone() calls and can enable -D warnings for test/example code not just the binary build.
nathanielc
force-pushed
the
chore/openapi
branch
from
d84566e to
c76b9b3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the openapi-generator-cli npm crate is a whole major version behind (6 vs 7) of the openapi-generator jar. This change removes the usage of the npm package as it was only a wrapper for downloading the jar and running it. Now we have a simple bash script that uses that latest stable release of openapi-generator.
This means we now have the fix for the extra .clone() calls and can enable -D warnings for test/example code not just the binary build.