Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added correctness test #248

Merged
merged 3 commits into from
Feb 1, 2024
Merged

feat: added correctness test #248

merged 3 commits into from
Feb 1, 2024

Conversation

3benbox
Copy link
Collaborator

@3benbox 3benbox commented Jan 29, 2024

No description provided.

@3benbox 3benbox mentioned this pull request Jan 29, 2024
Closed
@3benbox 3benbox force-pushed the feat/correctness-tests branch from 9402053 to 9db5ee9 Compare January 29, 2024 21:29
nathanielc
nathanielc reviewed Jan 30, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@3benbox 3benbox force-pushed the feat/correctness-tests branch from 670605c to c8ffc41 Compare January 31, 2024 02:09
@3benbox 3benbox temporarily deployed to github-tests-2024 January 31, 2024 17:12 — with GitHub Actions Inactive
@3benbox 3benbox temporarily deployed to github-tests-2024 January 31, 2024 19:04 — with GitHub Actions Inactive
@3benbox 3benbox force-pushed the feat/correctness-tests branch from 6c0a92f to 0b55e36 Compare January 31, 2024 19:18
@3benbox 3benbox requested a review from smrz2001 January 31, 2024 19:19
@3benbox 3benbox temporarily deployed to github-tests-2024 January 31, 2024 19:33 — with GitHub Actions Inactive
smrz2001
smrz2001 reviewed Jan 31, 2024
View reviewed changes
.github/workflows/rust-build-and-test.yml

correctness-tests:
runs-on: ubuntu-latest
environment: github-tests-2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we name the env just test?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having the cluster name so you know where it's going to deploy to

.github/workflows/rust-build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/rust-build-and-test.yml Show resolved Hide resolved
.github/workflows/rust-build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/rust-build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/rust-build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/rust-build-and-test.yml Outdated Show resolved Hide resolved
@3benbox
feat: added correctness test
2a94461 
fix: debug docker

fix: debug docker

fix: steps in setup

fix: steps in setup

fix: use root in Docker file

fix: use root in Docker file

fix: curl the file

fix: hermetic-driver flavor

fix: yq colors and debug

fix: yq colors and debug

fix: update network name and cleanup

fix: update network name and cleanup

feat: use pr comit for image tag

fix: run again

debug: testing ceramic-test image

fix: specify test types

fix: specify test types

fix: specify test types

fix: specify test types
@3benbox 3benbox force-pushed the feat/correctness-tests branch from 0b55e36 to 2a94461 Compare February 1, 2024 15:44
@3benbox 3benbox temporarily deployed to github-tests-2024 February 1, 2024 15:59 — with GitHub Actions Inactive
@3benbox 3benbox temporarily deployed to github-tests-2024 February 1, 2024 16:20 — with GitHub Actions Inactive
@3benbox 3benbox temporarily deployed to github-tests-2024 February 1, 2024 16:58 — with GitHub Actions Inactive
@3benbox 3benbox force-pushed the feat/correctness-tests branch from 09f304e to bdba396 Compare February 1, 2024 17:22
smrz2001
smrz2001 reviewed Feb 1, 2024
View reviewed changes
ci-scripts/get-update-network.sh
curl -LO https://raw.githubusercontent.com/3box/ceramic-tests/main/networks/basic-rust.yaml
./bin/yq -i '.spec.ceramic[0].ipfs.rust.image = strenv(RUST_CERAMIC_IMAGE)' basic-rust.yaml
./bin/yq -i '.metadata.name = strenv(KERAMIK_NETWORK_NAME)' basic-rust.yaml
./bin/yq --no-colors basic-rust.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: new line 😅

@3benbox 3benbox temporarily deployed to github-tests-2024 February 1, 2024 17:37 — with GitHub Actions Inactive
smrz2001
smrz2001 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@smrz2001 smrz2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@3benbox 3benbox added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 34289ae Feb 1, 2024
5 checks passed
@3benbox 3benbox deleted the feat/correctness-tests branch February 1, 2024 18:02
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielc nathanielc nathanielc left review comments

@smrz2001 smrz2001 smrz2001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3benbox @smrz2001 @nathanielc