Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: testing with loom and poll #312

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: testing with loom and poll #312

wants to merge 2 commits into from

Conversation

dbcfd
Copy link
Contributor

@dbcfd dbcfd commented Apr 18, 2024

No description provided.

@dbcfd dbcfd temporarily deployed to github-tests-2024 April 18, 2024 23:23 — with GitHub Actions Inactive
p2p/src/node.rs Outdated
rt.block_on(async {
let test_runner = TestRunnerBuilder::new().no_bootstrap().build().await.unwrap();
let got_peer_id = test_runner.client.local_peer_id().await.unwrap();
let expect_peer_id: PeerId = "12D3KooWFma2D63TG9ToSiRsjFkoNm2tTihScTBAEdXxinYk5rwE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the seed that makes this a constant?

https://github.com/ceramicnetwork/rust-ceramic/blob/b41f2f8c25eec92f233f561e4ed329d44b3ac880/p2p/src/node.rs#L1372C17-L1379C26

// public key 12D3KooWFma2D63TG9ToSiRsjFkoNm2tTihScTBAEdXxinYk5rwE
Ed25519Keypair::from_bytes(&[
    76, 8, 66, 244, 198, 186, 191, 7, 108, 12, 45, 193, 111, 155, 197, 0, 2, 9, 43,
    174, 135, 222, 200, 126, 94, 73, 205, 84, 201, 4, 70, 60, 88, 110, 199, 251,
    116, 51, 223, 7, 47, 24, 92, 233, 253, 5, 82, 72, 156, 214, 211, 143, 182, 206,
    76, 207, 121, 235, 48, 31, 50, 60, 219, 157,
])
.unwrap()

Should we be logging a warning of some kind when this publicly known secret is used so we can accidentally use this number somewhere?

@dbcfd dbcfd force-pushed the chore/loom branch 2 times, most recently from a2d58dd to 56c7a9b Compare May 1, 2024 14:06
@dbcfd dbcfd temporarily deployed to github-tests-2024 May 3, 2024 17:37 — with GitHub Actions Inactive
@dbcfd dbcfd temporarily deployed to github-tests-2024 May 3, 2024 18:05 — with GitHub Actions Inactive
Copy link
Contributor

@dav1do dav1do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good and useful, but the test infra is definitely pretty involved. One question, and once we merge #335 we can rebase and get this in.

p2p/src/behaviour/ceramic_peer_manager.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants