-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: testing with loom and poll #312
base: main
Are you sure you want to change the base?
Conversation
p2p/src/node.rs
Outdated
rt.block_on(async { | ||
let test_runner = TestRunnerBuilder::new().no_bootstrap().build().await.unwrap(); | ||
let got_peer_id = test_runner.client.local_peer_id().await.unwrap(); | ||
let expect_peer_id: PeerId = "12D3KooWFma2D63TG9ToSiRsjFkoNm2tTihScTBAEdXxinYk5rwE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the seed that makes this a constant?
// public key 12D3KooWFma2D63TG9ToSiRsjFkoNm2tTihScTBAEdXxinYk5rwE
Ed25519Keypair::from_bytes(&[
76, 8, 66, 244, 198, 186, 191, 7, 108, 12, 45, 193, 111, 155, 197, 0, 2, 9, 43,
174, 135, 222, 200, 126, 94, 73, 205, 84, 201, 4, 70, 60, 88, 110, 199, 251,
116, 51, 223, 7, 47, 24, 92, 233, 253, 5, 82, 72, 156, 214, 211, 143, 182, 206,
76, 207, 121, 235, 48, 31, 50, 60, 219, 157,
])
.unwrap()
Should we be logging a warning of some kind when this publicly known secret is used so we can accidentally use this number somewhere?
a2d58dd
to
56c7a9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good and useful, but the test infra is definitely pretty involved. One question, and once we merge #335 we can rebase and get this in.
No description provided.