fix: api batch with one invalid event could fail all #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
force-pushed
the
fix/aes-83-iod-long-streams
branch
from
cfea650 to
41778d4
Compare
dav1do
force-pushed
the
fix/api-batch-error
branch
from
56fc902 to
b1d3f1a
Compare
dav1do
force-pushed
the
fix/aes-83-iod-long-streams
branch
from
41778d4 to
4fed1e9
Compare
dav1do
force-pushed
the
fix/api-batch-error
branch
from
b1d3f1a to
a7ac586
Compare
dav1do
force-pushed
the
fix/api-batch-error
branch
from
a7ac586 to
d29672b
Compare
nathanielc
approved these changes
Jun 18, 2024
dav1do
force-pushed
the
fix/api-batch-error
branch
from
d29672b to
6ca3ffc
Compare
dav1do
force-pushed
the
fix/api-batch-error
branch
from
6ca3ffc to
9269898
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an API insert batch with a single event with invalid ordering could fail the entire set. It's still possible to "over fail" if something goes wrong somewhere (talking to the database or one of the events fails to parse), however both of those seem acceptable as the events are all parsed before being given to us so that should never happen. I'd like to change the signature to take an ceramic_event type in a follow up, but this is some progress in that direction. It builds on #390.